Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle lack of section.value["x-ms-enum"].name in UniqueXmsEnumName. #657

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Gracefully handle lack of section.value["x-ms-enum"].name in UniqueXmsEnumName. #657

merged 1 commit into from
Feb 1, 2024

Conversation

konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik commented Feb 1, 2024 •
edited
Loading

Solves #654

Also fixed issues with inconsistent state of change files and changelogs, due to the rush change and rush version --bump commands not being correctly called in previously merged PRs.

Related Teams discussion

Related issue:

@konrad-jamrozik konrad-jamrozik mentioned this pull request Feb 1, 2024
Open
@konrad-jamrozik konrad-jamrozik merged commit ddbf6b1 into main Feb 1, 2024
4 checks passed
@konrad-jamrozik konrad-jamrozik deleted the users/kojamroz/vbump branch February 1, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@mikeharder mikeharder Awaiting requested review from mikeharder mikeharder is a code owner

@AkhilaIlla AkhilaIlla Awaiting requested review from AkhilaIlla AkhilaIlla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konrad-jamrozik @weshaggard